NPE calculating discount during charging ----------------------------------------

Key: OVPMS-1066 URL: https://openvpms.atlassian.net/browse/OVPMS-1066 Project: VPMS Web Application Issue Type: Bug Components: Financial Affects Versions: 1.5-beta-2 Reporter: Tim Anderson Assignee: Tony De Keizer Priority: Minor Fix For: 1.5

From a 1.5-beta-2 error report: {noformat} java.lang.NullPointerException at java.math.BigDecimal.multiply(Unknown Source) at org.openvpms.archetype.rules.finance.discount.DiscountRules.calcDiscount(DiscountRules.java:303) at org.openvpms.archetype.rules.finance.discount.DiscountRules.calculateMaxDiscount(DiscountRules.java:272) at org.openvpms.archetype.rules.finance.discount.DiscountRules.calculateDiscount(DiscountRules.java:157) at org.openvpms.web.app.customer.PriceActItemEditor.calculateDiscpount(PriceActItemEditor.java:175) at org.openvpms.web.app.customer.PriceActItemEditor.updateDiscount(PriceActItemEditor.java:138) at org.openvpms.web.app.customer.charge.CustomerChargeActItemEditor.access$300(CustomerChargeActItemEditor.java:101) at org.openvpms.web.app.customer.charge.CustomerChargeActItemEditor$4.modified(CustomerChargeActItemEditor.java:237) at org.openvpms.web.component.property.ModifiableListeners.notifyListeners(ModifiableListeners.java:75) at org.openvpms.web.component.property.AbstractProperty.refresh(AbstractProperty.java:91) at org.openvpms.web.component.property.IMObjectProperty.modified(IMObjectProperty.java:509) at org.openvpms.web.component.property.IMObjectProperty.setValue(IMObjectProperty.java:145) at org.openvpms.web.app.customer.charge.CustomerChargeActItemEditor.productModified(CustomerChargeActItemEditor.java:398) at org.openvpms.web.component.im.edit.act.ActItemEditor.productModified(ActItemEditor.java:259) at org.openvpms.web.component.im.edit.act.ActItemEditor$1.modified(ActItemEditor.java:399) at org.openvpms.web.component.property.ModifiableListeners.notifyListeners(ModifiableListeners.java:75) at org.openvpms.web.component.edit.Editors.onModified(Editors.java:300) at org.openvpms.web.component.edit.Editors$1.modified(Editors.java:86) at org.openvpms.web.component.property.ModifiableListeners.notifyListeners(ModifiableListeners.java:75) at org.openvpms.web.component.property.AbstractProperty.refresh(AbstractProperty.java:91) at org.openvpms.web.component.property.IMObjectProperty.modified(IMObjectProperty.java:509) at org.openvpms.web.component.property.IMObjectProperty.setValue(IMObjectProperty.java:145) at org.openvpms.web.component.im.edit.AbstractIMObjectReferenceEditor.updateProperty(AbstractIMObjectReferenceEditor.java:395) at org.openvpms.web.component.im.edit.AbstractIMObjectReferenceEditor.setObject(AbstractIMObjectReferenceEditor.java:170) at org.openvpms.web.component.im.product.ProductReferenceEditor.setProduct(ProductReferenceEditor.java:183) at org.openvpms.web.component.im.product.ProductReferenceEditor.onSelected(ProductReferenceEditor.java:94) at org.openvpms.web.component.im.product.ProductReferenceEditor.onSelected(ProductReferenceEditor.java:61) at org.openvpms.web.component.im.edit.AbstractIMObjectReferenceEditor.onSelected(AbstractIMObjectReferenceEditor.java:264) at org.openvpms.web.component.im.edit.AbstractIMObjectReferenceEditor$2.selected(AbstractIMObjectReferenceEditor.java:135) at org.openvpms.web.component.im.select.IMObjectSelector.onSelected(IMObjectSelector.java:329) at org.openvpms.web.component.im.select.IMObjectSelector$4.onClose(IMObjectSelector.java:295) at org.openvpms.web.component.event.WindowPaneListener.windowPaneClosing(WindowPaneListener.java:39) at nextapp.echo2.app.WindowPane.fireWindowClosing(WindowPane.java:154) at org.openvpms.web.component.dialog.PopupWindow.fireWindowClosing(PopupWindow.java:259) at nextapp.echo2.app.WindowPane.userClose(WindowPane.java:795) at org.openvpms.web.component.dialog.PopupWindow.close(PopupWindow.java:183) at org.openvpms.web.component.dialog.PopupDialog.close(PopupDialog.java:329) at org.openvpms.web.component.im.query.BrowserDialog.close(BrowserDialog.java:227) at org.openvpms.web.component.dialog.PopupDialog.onOK(PopupDialog.java:245) at org.openvpms.web.component.im.query.BrowserDialog.onOK(BrowserDialog.java:207) at org.openvpms.web.component.im.query.BrowserDialog.onSelected(BrowserDialog.java:248) at org.openvpms.web.component.im.query.BrowserDialog$2.selected(BrowserDialog.java:143) at org.openvpms.web.component.im.query.AbstractBrowser.notifySelected(AbstractBrowser.java:111) at org.openvpms.web.component.im.query.TableBrowser.onSelect(TableBrowser.java:391) at org.openvpms.web.component.im.query.TableBrowser.access$100(TableBrowser.java:52) at org.openvpms.web.component.im.query.TableBrowser$1.onAction(TableBrowser.java:289) at org.openvpms.web.component.event.ActionListener.actionPerformed(ActionListener.java:41) at nextapp.echo2.app.Table.fireActionEvent(Table.java:332) at nextapp.echo2.app.Table.processInput(Table.java:586) at org.openvpms.web.component.table.KeyTable.processInput(KeyTable.java:136) at nextapp.echo2.app.update.ClientUpdateManager.process(ClientUpdateManager.java:116) at nextapp.echo2.app.update.UpdateManager.processClientUpdates(UpdateManager.java:89) at nextapp.echo2.webcontainer.ContainerSynchronizeService.renderUpdate(ContainerSynchronizeService.java:471) at nextapp.echo2.webrender.service.SynchronizeService.service(SynchronizeService.java:279) at nextapp.echo2.webrender.WebRenderServlet.process(WebRenderServlet.java:273) at org.openvpms.web.servlet.SpringWebContainerServlet.process(SpringWebContainerServlet.java:148) at nextapp.echo2.webrender.WebRenderServlet.doPost(WebRenderServlet.java:189) at javax.servlet.http.HttpServlet.service(HttpServlet.java:637) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:343) at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:109) at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:83) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:355) at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:78) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:355) at org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:187) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:355) at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:97) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:355) at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:79) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:355) at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:149) at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:237) at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:167) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489) at java.lang.Thread.run(Unknown Source) {noformat}

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://openvpms.atlassian.net/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

_______________________________________________ OpenVPMS Developers Mailing List developers@lists.openvpms.org To unsubscribe or change your subscription visit: http://lists.openvpms.org/listinfo/developers Posts from this mailing list can be viewed online and replied to in the OpenVPMS Developer's forum- http://tinyurl.com/openvdf