Home › Forums › Users › General User's Discussion ›

Invoice Reminders

Submitted by Ben_Charlton on Wed, 22/12/2021 - 14:14
in

So I only just noticed this - the invoice reminders report names reminders using the following expression:

 

($F{product.entity.type.target.name}==null?$F{reminderType.entity.name}:

($V{CountTypes}>1?($F{product.entity.type.target.name}+" [various]"):

($F{reminderType.entity.name}.equals( $F{product.entity.type.target.name})?

$F{reminderType.entity.name} :

   ($F{product.entity.type.target.name})+" ["+$F{reminderType.entity.name}+"]")))

Effectively you end up with a wierd reminder name: 
 

27/11/21 Walter Professional Fee [Desexing
27/12/21 Walter  Vaccinations [Proheart Sr12]
27/12/21 Walter  OTC [Bravecto Flea And Tick Control]
27/9/22 Walter + 1 other(s) Vaccinations [various]

 

Why are we using product type to define reminder names on  a report?

 

If anything I would have atleast reversed it - having the type in brackets....obviously I have modified my own report but wondered why this was designed this way.

 

‹ Update customer location Patient Locations ›

Comment viewing options

Select your preferred way to display the comments and click "Save settings" to activate your changes.

Re: Invoice Reminders

Submitted by tony on Tue, 04/01/2022 - 07:27.

Hi Ben,

I agree the use of product type doesn't make sense all the time but would in the case of multiple reminders of multipe types so they are at least grouped uder a meaningful name.  I expect the original author also thought referring to "Vaccinations" rather then "ProHeart sr12" was friendlier to the customer. 

Happy to hear alternatives and also hear from the user base as to their thoughts on what may be the best approach.  

Cheers
Tony

Syndicate content