[OpenVPMS Developers] [JIRA] Created: (OVPMS-949) Customer search results persist between selections

Submitted by tony on Tue, 22/06/2010 - 11:00

General developer's discussion

Customer search results persist between selections --------------------------------------------------

Key: OVPMS-949 URL: https://openvpms.atlassian.net/browse/OVPMS-949 Project: VPMS Web Application Issue Type: Improvement Components: Customer Affects Versions: 1.5 Reporter: Matt Costa Assignee: Tony De Keizer

The development will have customer search results remain between selections. This will allow the user to move to the next customer in the list and avoid the need to have to re type in search criteria such as name and patient.

The Name, Patient and Contact boxes would remain emptied, to allow new searches to be started easily.

-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://openvpms.atlassian.net/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

_______________________________________________ OpenVPMS Developers Mailing List developers@lists.openvpms.org To unsubscribe or change your subscription visit: http://lists.openvpms.org/listinfo/developers Posts from this mailing list can be viewed online and replied to in the OpenVPMS Developer's forum- http://tinyurl.com/openvdf

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Sun, 15/08/2010 - 13:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12004#action_12004 ]

Matt Costa commented on OVPMS-949: ----------------------------------

The development project linked to this JIRA is reopened and a costing required. Cheers :)

> Customer search results persist between selections > -------------------------------------------------- > > Key: OVPMS-949 > URL: https://openvpms.atlassian.net/browse/OVPMS-949 > Project: VPMS Web Application > Issue Type: Improvement > Components: Customer > Affects Versions: 1.5 > Reporter: Matt Costa > Assignee: Tony De Keizer > > The development will have customer search results remain between selections. This will allow the user to move to the next customer in the list and avoid the need to have to re type in search criteria such as name and patient. > The Name, Patient and Contact boxes would remain emptied, to allow new searches to be started easily.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Sun, 15/08/2010 - 23:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12005#action_12005 ]

Tim Anderson commented on OVPMS-949: ------------------------------------

{quote} The Name, Patient and Contact boxes would remain emptied, to allow new searches to be started easily. {quote} A problem with this is that the displayed results don't correspond to the search criteria. E,g, suppose the original query was for all customers starting with 'B', and the user had navigated to the 7th page and selected the 5 row. On reopening the dialog, it would redisplay the query results for 'B', page 7, with row 5 selected, but the search criteria would be cleared. If you click 'next page', what happens? Does it: # display page 1 of the search results of the query with no criteria? # display page 8 of the search results of the previous query? # something else?

[OpenVPMS Developers] [JIRA] Issue Comment Edited: (OVPMS-949) C

Submitted by tony on Sun, 15/08/2010 - 23:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12005#action_12005 ]

Tim Anderson edited comment on OVPMS-949 at 8/15/10 11:56 AM: --------------------------------------------------------------

{quote} The Name, Patient and Contact boxes would remain emptied, to allow new searches to be started easily. {quote} A problem with this is that the displayed results don't correspond to the search criteria. E,g, suppose the original query was for all customers starting with 'B', and the user had navigated to the 7th page and selected the 5 row. On reopening the dialog, it would redisplay the query results for 'B', page 7, with row 5 selected, but the search criteria would be cleared. If you click 'next page', what happens? Does it display: # page 1 of the search results of the query with no criteria? # page 8 of the search results of the previous query? # something else?

was (Author: tanderson): {quote} The Name, Patient and Contact boxes would remain emptied, to allow new searches to be started easily. {quote} A problem with this is that the displayed results don't correspond to the search criteria. E,g, suppose the original query was for all customers starting with 'B', and the user had navigated to the 7th page and selected the 5 row. On reopening the dialog, it would redisplay the query results for 'B', page 7, with row 5 selected, but the search criteria would be cleared. If you click 'next page', what happens? Does it: # display page 1 of the search results of the query with no criteria? # display page 8 of the search results of the previous query? # something else?

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Mon, 16/08/2010 - 13:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12007#action_12007 ]

Matt Costa commented on OVPMS-949: ----------------------------------

Despite the user inputs for search criteria being cleared, would the original query still be able to be stored? I had assumed this would be the mechanism for storing the search; ie. Store a) search query b) current selection/current page

Pressing page navigation buttons would re execute the query with different pagination constraints. Pressing "Find" replaces the current query.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Thu, 19/08/2010 - 01:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12015#action_12015 ]

Tim Anderson commented on OVPMS-949: ------------------------------------

I guess I could restore the query, execute it and display the results and then clear the search criteria. This would mean that pagination would work as per the original query. If you press find, then it gets reset. Not sure if that's what a user would expect. Would a reset/clear button that cleared the search criteria and results be better?

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Thu, 19/08/2010 - 21:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12016#action_12016 ]

Matt Costa commented on OVPMS-949: ----------------------------------

I could see that might confuse some users initially. I still think the time savings might be worth the training.

What if; a) The current search criteria were represented somewhere as static text: ie. Current Search Criteria: Name: "Jo Blow" Patient "Jimmy" Contact "65 R" > 4 pages returned OR Current Search Criteria: No criteria entered

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Thu, 19/08/2010 - 22:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12017#action_12017 ]

Matthew Young commented on OVPMS-949: -------------------------------------

What if instead of the search box being cleared the search criteria remain but the search box is focused with the text selected? That way to start a new search all you need to do is backspace and start typing.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Thu, 19/08/2010 - 22:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12018#action_12018 ]

Matt Costa commented on OVPMS-949: ----------------------------------

Problem is that you have multiple fields with criteria in them... :(

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Thu, 19/08/2010 - 23:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12019#action_12019 ]

Tim Anderson commented on OVPMS-949: ------------------------------------

The simplest approach is to relaunch the search dialog with the original query parameters set and re-run the query. A button to start over would return the query to its empty state. Call this button "Reset", "Clear", "Restart", "New Query" or whatever, and include a shortcut.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Thu, 19/08/2010 - 23:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12020#action_12020 ]

Matthew Young commented on OVPMS-949: -------------------------------------

That's right I forgot about the multiple search boxes.

I really think the search criteria should remain there- what if you had just made a typo and then had to re-enter the whole query again. A button sounds like a good solution to me.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Fri, 20/08/2010 - 00:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12021#action_12021 ]

Matt Costa commented on OVPMS-949: ----------------------------------

Sounds good. Lets make sure it has a hot key :)

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Fri, 20/08/2010 - 01:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12022#action_12022 ]

Tim Anderson commented on OVPMS-949: ------------------------------------

OK - so you happy for this to go into the customers, patients and suppliers? Looking at 7 hours work.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Fri, 20/08/2010 - 11:01.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12023#action_12023 ]

Matt Costa commented on OVPMS-949: ----------------------------------

I've thought more about this one over night and not sure I am happy (sorry). The most common use case is the new search. We have just added a new click to that use case. We are seeking to facilitate a less common use case, the repeat search.

What about this, we go back one step to the Select button. Instead of "Select" we have two buttons "Last Search" and "New Search"

Last search opens the previous search complete with all items in fields, ready for modification, pagination whatever. New Search opens a blank search page as current.

Whaddya reckon?

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Fri, 20/08/2010 - 12:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12024#action_12024 ]

Tim Anderson commented on OVPMS-949: ------------------------------------

Can certainly do that.

If in future you wanted prior searches (not just last one), how would you envisage that being done? I suspect I'd do it by having a summary of the query next to the current Select button in a combo box. This would display the most recent query. The Last Search (maybe Find Again?) would use the query selected from the combo box.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Customer sea

Submitted by tony on Fri, 20/08/2010 - 13:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12025#action_12025 ]

Matt Costa commented on OVPMS-949: ----------------------------------

Awesome. Maybe we should take that model straight back to the users? I reckon it would be very popular.

[OpenVPMS Developers] [JIRA] Updated: (OVPMS-949) Add 'Find Agai

Submitted by tony on Mon, 06/09/2010 - 01:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Anderson updated OVPMS-949: -------------------------------

Summary: Add 'Find Again' support to relaunch the customer selection dialog with the previous input parameters and results (was: Customer search results persist between selections) Description: To save time re-keying query critieria and paging through the results, support is required to open the customer selection dialog with the state of the prior query. This should: * have the prior query criteria (i.e prior values for "Search", "Patient", "Contact" etc) * display the selected page in the query results * highlight the selected row

was: The development will have customer search results remain between selections. This will allow the user to move to the next customer in the list and avoid the need to have to re type in search criteria such as name and patient.

The Name, Patient and Contact boxes would remain emptied, to allow new searches to be started easily.

Updated JIRA description to reflect current requirements. There are a couple of L&F possibilities: # add a 'Find Again' button at the bottom of the workspace (e.g next to New) #* The shortcut would be Alt-G to be consistent with other apps. This means the Reporting workspace shortcut needs to change. #* Need to change each workspace to add Find Again button. For customers, this applies to 7 workspaces. Estimate 4 hours # as above but rename the 'Select' button to 'Find'. 'Find' button shortcut is 'Alt-F' #* Estimate 4 hours for customers, as above # drop the Select button altogether and place 'Find' and 'Find Again' at the bottom of the workspace (e.g next to 'New') #* Need to change each workspace to add 'Find' and 'Find Again' button #* Estimate 4 hours for customers. # rename the Select button to 'Find', and add 'Find Again' button next to it Only need to change one place and Find and Find again are available in all similar workspaces. Estimate 3 hours # rename the Select button to 'Find', with shortcut Alt-F. Add a hidden shortcut Alt-G to launch 'Find Again'. Alt-G is displayed as a tooltip on 'Find' Only need to change one place and Find and Find again are available in all similar workspaces. Estimate 3 hours

There are a couple of implementation possibilities: * cache the prior query browser and reopen it on 'Find Again' This is straightforward, but means that up to 80 customers are kept in memory per user due to query results caching (4 pages, 20 customers per page) Each takes about 5K of memory (based on serialized state which overstates memory usage) This grows for customers with large no.s of relationships e.g one customer with 105 patient relationships used 31K The cache can automatically drop back to 20 customers if memory is low (all but the current page can be garbage collected) If you assume 5K per customer, then each user could be using 400K of memory to save the prior query results. This approach can be applied in one place and work for all workspaces that currently have a Select button. Another disadvantage is that the query results reflect the time when the query was executed (i.e excludes subsequent updates) Estimate 1 hour + L&F time above

* save the query criteria, page and selected row and restore on 'Find Again' This is more involved, but scales better for large numbers of users. Disadvantage is that each browser that needs Find Again support needs to be changed to support saving and restoring its state. For the customer browser alone, estimate 4 hours to implement + L&F time above

> Add 'Find Again' support to relaunch the customer selection dialog with the previous input parameters and results > ----------------------------------------------------------------------------------------------------------------- > > Key: OVPMS-949 > URL: https://openvpms.atlassian.net/browse/OVPMS-949 > Project: VPMS Web Application > Issue Type: Improvement > Components: Customer > Affects Versions: 1.5 > Reporter: Matt Costa > Assignee: Tony De Keizer > > To save time re-keying query critieria and paging through the results, support is required to open the customer selection dialog with the state of the prior query. > This should: > * have the prior query criteria (i.e prior values for "Search", "Patient", "Contact" etc) > * display the selected page in the query results > * highlight the selected row

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Add 'Find Ag

Submitted by tony on Tue, 07/09/2010 - 21:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12050#action_12050 ]

Matt Costa commented on OVPMS-949: ----------------------------------

Thanks Tim, I am going to post option 4 and implementation approach "save the query criteria, page and selected row and restore on 'Find Again'"

This equates to 4hrs + 4 Hrs = 8 Hrs.

Many thanks.

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Add 'Find Ag

Submitted by tony on Tue, 07/09/2010 - 21:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12051#action_12051 ]

Matt Costa commented on OVPMS-949: ----------------------------------

Correction: "This equates to 4hrs + 4 Hrs = 8 Hrs." should read "This equates to 3hrs + 4 Hrs = 7 Hrs."

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Add 'Find Ag

Submitted by tony on Tue, 07/09/2010 - 21:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12052#action_12052 ]

Tim Anderson commented on OVPMS-949: ------------------------------------

Just remember that this only applies to customers. If you want it for other workspaces, then you need to either: * cache the prior query browser and reopen it on 'Find Again' * implement "save the query criteria, page and selected row and restore" for each query

[OpenVPMS Developers] [JIRA] Commented: (OVPMS-949) Add 'Find Ag

Submitted by tony on Wed, 08/09/2010 - 00:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12053#action_12053 ]

Matt Costa commented on OVPMS-949: ----------------------------------

That's fine Tim.

[OpenVPMS Developers] [JIRA] Updated: (OVPMS-949) Add 'Find Agai

Submitted by tony on Wed, 13/10/2010 - 19:00.

[ https://openvpms.atlassian.net/browse/OVPMS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Anderson updated OVPMS-949: -------------------------------

Fix Version/s: 1.5

> Add 'Find Again' support to relaunch the customer selection dialog with the previous input parameters and results > ----------------------------------------------------------------------------------------------------------------- > > Key: OVPMS-949 > URL: https://openvpms.atlassian.net/browse/OVPMS-949 > Project: VPMS Web Application > Issue Type: Improvement > Components: Customer > Affects Versions: 1.5 > Reporter: Matt Costa > Assignee: Tim Anderson > Fix For: 1.5 > > > To save time re-keying query critieria and paging through the results, support is required to open the customer selection dialog with the state of the prior query. > This should: > * have the prior query criteria (i.e prior values for "Search", "Patient", "Contact" etc) > * display the selected page in the query results > * highlight the selected row

[OpenVPMS Developers] [JIRA] Created: (OVPMS-949) Customer search results persist between selections

Comment viewing options