1.7 release - Update the Interactive Invoice Mail action
When the maildialog for an interactive invoice print is defined can we set the default email contact to the one set marked for Billing purposes. Similar to what happens with statement finalization. I would also argue if we could set the subject automatically to "Invoice from %Practice Name%"
This would need a rewrite of the interactive Maildialog class to enable passing a reference to the subject or the content of the maileditor and allow passing of preset messages and subject lines and still allowing interactive editing of the mail before sending.
Ater mail is successful sent invoice to printed ( I actually thought this was the case in 1.7 but it doesnt seem to work. checking the listener
InteractivePrinter.java
Line 508
/**
* Invoked when the print job is mailed instead.
* Notifies any registered listener that the printing has been skipped.
*/
protected void mailed() {
if (listener != null) {
listener.skipped();
}
}could this be change to listener.printed(null)?
Finally, is it possible to tag the contect of all email with a usertag - so even without auditting mail that is sent to a client via a SMTP client and then stored in SENT mail is actually able to be attributed to a logged in USER.
Re: 1.7 release - Update the Interactive Invoice Mail action
Its probably easiest if the customer contact just defaults to the BILLING email contact if one is present, and the customer's preferred email contact if not, whenever a print dialog for the customer is displayed.
There is already limited support for setting the mail subject, by setting the emailSubject node of entity.documentTemplate. This doesn't support token replacement.
I don't think the print dialog should also print if you click Mail. Sounds counter-intuitive.
There's no support for tagging email with a user tag. This could be supported via a User parameter. If the template declares this, it would be populated with the user login name (c.f. the IsEmail parameter)
Re: 1.7 release - Update the Interactive Invoice Mail action
I actually assumed that this listener which is triggered after the mail is sent feeds back into the tasklistener interface. The printed call just notifys the listener that the task has been completed as opposed to the current state which is to notify that the task has been skipped...I assumed that if we notifying the task had been completed the result would be the document is flagged as printed and will not reappear to on the docs to print list for that client at checkout
Looking at it now I just realized all printed does is call notifycompleted....which will be called after the dialog is closed anyway...
my java Learner plates couldnt quite get me down into the code far enough to find where during the printing process the setprinted flag is set.
We are often processing 2 or 3 invoices on any given day for some clients - due to a requirement that each patient be billed seperately. Once finalized each invoice is mailed and a subject line of invoice : for patientname is manually entered. However when we are ready to print the next invoice the current behaviour means both documents appear in the interactive tobeprinted on checkout window. Which is highly confusing.
Re: 1.7 release - Update the Interactive Invoice Mail action
When you do a checkout, the print dialog selects all unprinted documents for the current customer and patient from the earliest date/time of:
There is a JIRA for 1.8 to update the printed flag when a document is mailed: https://openvpms.atlassian.net/browse/OVPMS-1353
This should limit the documents you see.
With regards to the manually entry of the patient name, it should be possible to change the code so that macro expansion of the entity.documentTemplate emailSubject line is suppressed until the template is actually used. Alternatively, if could be extended to support xpath expressions.